patch: Update timout for failvoer to 190s#47
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Tenacity retry configuration used when polling Sentinel to determine whether a coordinated primary failover is still in progress, aiming to better align the polling window with Sentinel’s failover timeout expectations.
Changes:
- Increased retry attempts in
SentinelClient.is_failover_in_progressfrom 5 to 19. - Increased the fixed wait between retries from 2s to 10s.
- Added inline comments describing the intended overall wait behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mehdi-Bendriss
approved these changes
Apr 21, 2026
reneradoi
approved these changes
Apr 21, 2026
Contributor
reneradoi
left a comment
reneradoi
left a comment
There was a problem hiding this comment.
We should state this in the docs, otherwise users might complain why it takes so long to remove units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adjusts the retry logic for the coordinated primary failover process to better accommodate the expected duration of a failover operation. The main change is to increase the total wait time and interval between retries, ensuring the process aligns with the 3-minute timeout used by Sentinel.
Failover process reliability:
failover_primary_coordinatedmethod insrc/common/client.py, allowing up to 3 minutes and 10 seconds for the failover to complete, matching Sentinel's timeout behavior.